diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2014-11-21 20:22:32 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-12-12 15:26:31 -0500 |
| commit | 1746fbe5656b1b10064913b9293a4590ec0b7f27 (patch) | |
| tree | 0c654ad315382dc40b65b61e38df9ee9d4172936 /drivers/ide | |
| parent | 6ce4436c9cbe903af935291aa219fd6f4c85722d (diff) | |
| download | lwn-1746fbe5656b1b10064913b9293a4590ec0b7f27.tar.gz lwn-1746fbe5656b1b10064913b9293a4590ec0b7f27.zip | |
IDE: Deletion of an unnecessary check before the function call "module_put"
The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ide')
| -rw-r--r-- | drivers/ide/ide.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c index 2ce6268a2734..e29b02ca9e91 100644 --- a/drivers/ide/ide.c +++ b/drivers/ide/ide.c @@ -101,8 +101,7 @@ void ide_device_put(ide_drive_t *drive) struct device *host_dev = drive->hwif->host->dev[0]; struct module *module = host_dev ? host_dev->driver->owner : NULL; - if (module) - module_put(module); + module_put(module); #endif put_device(&drive->gendev); } |