diff options
| author | Liao Chang <liaochang1@huawei.com> | 2023-08-08 09:29:48 +0800 |
|---|---|---|
| committer | Andi Shyti <andi.shyti@kernel.org> | 2023-08-10 10:12:55 +0200 |
| commit | 9a648b3f56c49551081b9560392e9a640aa3d5cb (patch) | |
| tree | 246bca0abc70f1ade21d2c0574e7f81ace0b0e1d /drivers/i2c | |
| parent | 45a7a0524bff52360f82277f165bbdef7a199484 (diff) | |
| download | lwn-9a648b3f56c49551081b9560392e9a640aa3d5cb.tar.gz lwn-9a648b3f56c49551081b9560392e9a640aa3d5cb.zip | |
i2c: xlp9xx: Use dev_err_probe in probe function
Use the dev_err_probe function instead of dev_err in the probe function
so that the printed message includes the return value and also handles
-EPROBE_DEFER nicely.
Signed-off-by: Liao Chang <liaochang1@huawei.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20230808012954.1643834-4-liaochang1@huawei.com
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/busses/i2c-xlp9xx.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c index f59e8c544f36..08a59a920929 100644 --- a/drivers/i2c/busses/i2c-xlp9xx.c +++ b/drivers/i2c/busses/i2c-xlp9xx.c @@ -529,10 +529,8 @@ static int xlp9xx_i2c_probe(struct platform_device *pdev) err = devm_request_irq(&pdev->dev, priv->irq, xlp9xx_i2c_isr, 0, pdev->name, priv); - if (err) { - dev_err(&pdev->dev, "IRQ request failed!\n"); - return err; - } + if (err) + return dev_err_probe(&pdev->dev, err, "IRQ request failed!\n"); init_completion(&priv->msg_complete); priv->adapter.dev.parent = &pdev->dev; |