diff options
| author | Dmitry Osipenko <digetx@gmail.com> | 2020-03-24 22:12:17 +0300 |
|---|---|---|
| committer | Thierry Reding <treding@nvidia.com> | 2020-05-08 12:42:33 +0200 |
| commit | a70ff65601f1016cb164d2847e9f370e2ed22b39 (patch) | |
| tree | 175e60e51ff3be053004ba494bc80c9ce6ce19ef /drivers/i2c/busses/i2c-tegra.c | |
| parent | 566c05f7cd9a5c6a257d19d4fb91ce35b3b27fb6 (diff) | |
| download | lwn-a70ff65601f1016cb164d2847e9f370e2ed22b39.tar.gz lwn-a70ff65601f1016cb164d2847e9f370e2ed22b39.zip | |
i2c: tegra: Synchronize DMA before termination
DMA transfer could be completed, but CPU (which handles DMA interrupt)
may get too busy and can't handle the interrupt in a timely manner,
despite of DMA IRQ being raised. In this case the DMA state needs to
synchronized before terminating DMA transfer in order not to miss the
DMA transfer completion.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Diffstat (limited to 'drivers/i2c/busses/i2c-tegra.c')
| -rw-r--r-- | drivers/i2c/busses/i2c-tegra.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 9232038ccb40..7c92e91a1cc2 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -1219,6 +1219,15 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, time_left = tegra_i2c_wait_completion_timeout( i2c_dev, &i2c_dev->dma_complete, xfer_time); + /* + * Synchronize DMA first, since dmaengine_terminate_sync() + * performs synchronization after the transfer's termination + * and we want to get a completion if transfer succeeded. + */ + dmaengine_synchronize(i2c_dev->msg_read ? + i2c_dev->rx_dma_chan : + i2c_dev->tx_dma_chan); + dmaengine_terminate_sync(i2c_dev->msg_read ? i2c_dev->rx_dma_chan : i2c_dev->tx_dma_chan); |