diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2023-01-29 16:42:46 +0800 |
|---|---|---|
| committer | Suzuki K Poulose <suzuki.poulose@arm.com> | 2023-01-30 09:42:35 +0000 |
| commit | c88a15d9dd7dfabe2a13473fd1f9c4b9cd1b62c9 (patch) | |
| tree | 32a81036b216a1471abe64e5f0083e8871ae62ef /drivers/hwtracing | |
| parent | 0c1ccc158bbc4d14fe1a52e99f3933f34f309dac (diff) | |
| download | lwn-c88a15d9dd7dfabe2a13473fd1f9c4b9cd1b62c9.tar.gz lwn-c88a15d9dd7dfabe2a13473fd1f9c4b9cd1b62c9.zip | |
coresight: tpda: fix return value check in tpda_probe()
devm_ioremap_resource() never returns NULL pointer, it
will return ERR_PTR() when it fails, so replace the check
with IS_ERR().
Fixes: 5b7916625c01 ("Coresight: Add TPDA link driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
[ Fix return value to the PTR_ERR(base) ]
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20230129084246.537694-1-yangyingliang@huawei.com
Diffstat (limited to 'drivers/hwtracing')
| -rw-r--r-- | drivers/hwtracing/coresight/coresight-tpda.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hwtracing/coresight/coresight-tpda.c b/drivers/hwtracing/coresight/coresight-tpda.c index 382d648529e7..f712e112ecff 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.c +++ b/drivers/hwtracing/coresight/coresight-tpda.c @@ -145,8 +145,8 @@ static int tpda_probe(struct amba_device *adev, const struct amba_id *id) dev_set_drvdata(dev, drvdata); base = devm_ioremap_resource(dev, &adev->res); - if (!base) - return -ENOMEM; + if (IS_ERR(base)) + return PTR_ERR(base); drvdata->base = base; spin_lock_init(&drvdata->spinlock); |