diff options
| author | Gustavo A. R. Silva <gustavoars@kernel.org> | 2022-01-24 20:13:53 -0600 |
|---|---|---|
| committer | Bjorn Andersson <bjorn.andersson@linaro.org> | 2022-03-11 14:56:15 -0600 |
| commit | 3e5f1ff7e4f297b928fb579fa1e8ec65a400162e (patch) | |
| tree | b1e509576f16955e388793bf70c08039742fdd86 /drivers/hwspinlock/stm32_hwspinlock.c | |
| parent | 571c3496e3c20444d5a2a5d4c00e608f26339505 (diff) | |
| download | lwn-3e5f1ff7e4f297b928fb579fa1e8ec65a400162e.tar.gz lwn-3e5f1ff7e4f297b928fb579fa1e8ec65a400162e.zip | |
hwspinlock: stm32: Use struct_size() helper in devm_kzalloc()
Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worst scenario, could lead to heap overflows.
Also, address the following sparse warnings:
drivers/hwspinlock/stm32_hwspinlock.c:84:32: warning: using sizeof on a flexible structure
Link: https://github.com/KSPP/linux/issues/174
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220125021353.GA29777@embeddedor
Diffstat (limited to 'drivers/hwspinlock/stm32_hwspinlock.c')
| -rw-r--r-- | drivers/hwspinlock/stm32_hwspinlock.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/hwspinlock/stm32_hwspinlock.c b/drivers/hwspinlock/stm32_hwspinlock.c index 5bd11a7fab65..bb5c7e5f7a80 100644 --- a/drivers/hwspinlock/stm32_hwspinlock.c +++ b/drivers/hwspinlock/stm32_hwspinlock.c @@ -73,15 +73,13 @@ static int stm32_hwspinlock_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct stm32_hwspinlock *hw; void __iomem *io_base; - size_t array_size; int i, ret; io_base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(io_base)) return PTR_ERR(io_base); - array_size = STM32_MUTEX_NUM_LOCKS * sizeof(struct hwspinlock); - hw = devm_kzalloc(dev, sizeof(*hw) + array_size, GFP_KERNEL); + hw = devm_kzalloc(dev, struct_size(hw, bank.lock, STM32_MUTEX_NUM_LOCKS), GFP_KERNEL); if (!hw) return -ENOMEM; |