diff options
| author | Ben Hutchings <ben@decadent.org.uk> | 2013-03-16 06:32:16 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-03-20 13:05:00 -0700 |
| commit | 969ff7dc5423e50938e7b42b59fe1163aced714c (patch) | |
| tree | ce4ad064d2103322f8b11964f1e089909982a5fc /drivers/hwmon | |
| parent | 81da76ae314c66e32b8c06b0ce155a5b61670dd7 (diff) | |
| download | lwn-969ff7dc5423e50938e7b42b59fe1163aced714c.tar.gz lwn-969ff7dc5423e50938e7b42b59fe1163aced714c.zip | |
hwmon: (sht15) Fix memory leak if regulator_enable() fails
Commit 3e78080f8148 ('hwmon: (sht15) Check return value of
regulator_enable()') depends on the use of devm_kmalloc() for automatic
resource cleanup in the failure cases, which was introduced in 3.7. In
older stable branches, explicit cleanup is needed.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/sht15.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/sht15.c b/drivers/hwmon/sht15.c index eb0180221d04..c68963023cab 100644 --- a/drivers/hwmon/sht15.c +++ b/drivers/hwmon/sht15.c @@ -930,7 +930,7 @@ static int __devinit sht15_probe(struct platform_device *pdev) if (ret != 0) { dev_err(&pdev->dev, "failed to enable regulator: %d\n", ret); - return ret; + goto err_free_data; } /* |