diff options
| author | Axel Lin <axel.lin@ingics.com> | 2014-07-30 11:13:52 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-09-05 16:28:35 -0700 |
| commit | 06f770aa658cef847c8022bdff436885bde3f7bf (patch) | |
| tree | b04d010cbecb0eb29ba461e8da19fe199ae13cfb /drivers/hwmon | |
| parent | 6dbbe154751f97308e0cd029f0b15f7685897ecf (diff) | |
| download | lwn-06f770aa658cef847c8022bdff436885bde3f7bf.tar.gz lwn-06f770aa658cef847c8022bdff436885bde3f7bf.zip | |
hwmon: (ads1015) Fix off-by-one for valid channel index checking
commit 56de1377ad92f72ee4e5cb0faf7a9b6048fdf0bf upstream.
Current code uses channel as array index, so the valid channel value is
0 .. ADS1015_CHANNELS - 1.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/ads1015.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c index 2798246ad814..c581602e1e07 100644 --- a/drivers/hwmon/ads1015.c +++ b/drivers/hwmon/ads1015.c @@ -184,7 +184,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client) } channel = be32_to_cpup(property); - if (channel > ADS1015_CHANNELS) { + if (channel >= ADS1015_CHANNELS) { dev_err(&client->dev, "invalid channel index %d on %s\n", channel, node->full_name); |