diff options
| author | Axel Lin <axel.lin@gmail.com> | 2010-11-08 20:40:34 -0500 |
|---|---|---|
| committer | Guenter Roeck <guenter.roeck@ericsson.com> | 2010-11-11 09:32:07 -0800 |
| commit | f0030d87be3cb2eb9eac633d09cb5d9f107ed0c6 (patch) | |
| tree | a75cfa0e336e81c5bfcbd958a98a153ec39c80d6 /drivers/hwmon | |
| parent | f7334b4ca9108a86b64fbd0f435f44b2113ee053 (diff) | |
| download | lwn-f0030d87be3cb2eb9eac633d09cb5d9f107ed0c6.tar.gz lwn-f0030d87be3cb2eb9eac633d09cb5d9f107ed0c6.zip | |
hwmon: (ad7414) Return proper error code for ad7414_probe()
Return proper error if i2c_check_functionality reports
the adapter does not support the capability we need.
Also remove unneeded initialization for err variable.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Sean MacLennan <smaclennan@pikatech.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/ad7414.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/hwmon/ad7414.c b/drivers/hwmon/ad7414.c index 1e4c21fc1a89..86d822aa9bbf 100644 --- a/drivers/hwmon/ad7414.c +++ b/drivers/hwmon/ad7414.c @@ -178,11 +178,13 @@ static int ad7414_probe(struct i2c_client *client, { struct ad7414_data *data; int conf; - int err = 0; + int err; if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA | - I2C_FUNC_SMBUS_READ_WORD_DATA)) + I2C_FUNC_SMBUS_READ_WORD_DATA)) { + err = -EOPNOTSUPP; goto exit; + } data = kzalloc(sizeof(struct ad7414_data), GFP_KERNEL); if (!data) { |