diff options
author | Rasmus Villemoes <linux@rasmusvillemoes.dk> | 2021-07-02 15:37:12 +0200 |
---|---|---|
committer | Bartosz Golaszewski <bgolaszewski@baylibre.com> | 2021-07-18 14:52:30 +0200 |
commit | ec7099fdea8025988710ee6fecfd4e4210c29ab5 (patch) | |
tree | b47df040d6deeb7cdf047c11149456dc496a7b46 /drivers/hwmon | |
parent | e73f0f0ee7541171d89f2e2491130c7771ba58d3 (diff) | |
download | lwn-ec7099fdea8025988710ee6fecfd4e4210c29ab5.tar.gz lwn-ec7099fdea8025988710ee6fecfd4e4210c29ab5.zip |
Revert "gpio: mpc8xxx: change the gpio interrupt flags."
This reverts commit 3d5bfbd9716318b1ca5c38488aa69f64d38a9aa5.
When booting with threadirqs, it causes a splat
WARNING: CPU: 0 PID: 29 at kernel/irq/handle.c:159 __handle_irq_event_percpu+0x1ec/0x27c
irq 66 handler irq_default_primary_handler+0x0/0x1c enabled interrupts
That splat later went away with commit 81e2073c175b ("genirq: Disable
interrupts for force threaded handlers"), which got backported to
-stable. However, when running an -rt kernel, the splat still
exists. Moreover, quoting Thomas Gleixner [1]
But 3d5bfbd97163 ("gpio: mpc8xxx: change the gpio interrupt flags.")
has nothing to do with that:
"Delete the interrupt IRQF_NO_THREAD flags in order to gpio interrupts
can be threaded to allow high-priority processes to preempt."
This changelog is blatantly wrong. In mainline forced irq threads
have always been invoked with softirqs disabled, which obviously
makes them non-preemptible.
So the patch didn't even do what its commit log said.
[1] https://lore.kernel.org/lkml/871r8zey88.ffs@nanos.tec.linutronix.de/
Cc: stable@vger.kernel.org # v5.9+
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Diffstat (limited to 'drivers/hwmon')
0 files changed, 0 insertions, 0 deletions