diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-04-13 13:50:04 +0300 |
|---|---|---|
| committer | Wei Liu <wei.liu@kernel.org> | 2021-04-16 10:36:33 +0000 |
| commit | 3e9bf43f7f7a46f21ec071cb47be92d0874c48da (patch) | |
| tree | 00bfee82ecc1c1b8d9c18fdd7bc873453b9c3416 /drivers/hv | |
| parent | 61d74d8e39c88cd5d4300162a0cf96b01b8218d2 (diff) | |
| download | lwn-3e9bf43f7f7a46f21ec071cb47be92d0874c48da.tar.gz lwn-3e9bf43f7f7a46f21ec071cb47be92d0874c48da.zip | |
Drivers: hv: vmbus: Use after free in __vmbus_open()
The "open_info" variable is added to the &vmbus_connection.chn_msg_list,
but the error handling frees "open_info" without removing it from the
list. This will result in a use after free. First remove it from the
list, and then free it.
Fixes: 6f3d791f3006 ("Drivers: hv: vmbus: Fix rescind handling issues")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andrea Parri <parri.andrea@gmail.com>
Link: https://lore.kernel.org/r/YHV3XLCot6xBS44r@mwanda
Signed-off-by: Wei Liu <wei.liu@kernel.org>
Diffstat (limited to 'drivers/hv')
| -rw-r--r-- | drivers/hv/channel.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index db30be8f9cce..1c5a418c1962 100644 --- a/drivers/hv/channel.c +++ b/drivers/hv/channel.c @@ -653,7 +653,7 @@ static int __vmbus_open(struct vmbus_channel *newchannel, if (newchannel->rescind) { err = -ENODEV; - goto error_free_info; + goto error_clean_msglist; } err = vmbus_post_msg(open_msg, |