diff options
| author | Jiri Slaby <jirislaby@gmail.com> | 2008-10-23 01:47:30 +0200 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2008-10-23 01:47:30 +0200 |
| commit | 0f2c5945a917e776ccd394f0e1924e9502c2795f (patch) | |
| tree | c79e952888110c7a1d33b42ed2e70a7bd626e70b /drivers/hid/hidraw.c | |
| parent | b4d8e4736c94e78fd846dca0c95a3a0710582584 (diff) | |
| download | lwn-0f2c5945a917e776ccd394f0e1924e9502c2795f.tar.gz lwn-0f2c5945a917e776ccd394f0e1924e9502c2795f.zip | |
HID: fix lock imbalance in hidraw
Add omitted unlock_kernel() to hidraw_ioctl().
Added in 979c407e3b89b606e810fa494ef316896eadbfad
(HID: Push down BKL into ioctl handler in hidraw).
Corresponing sparse warning:
drivers/hid/hidraw.c:267:9: warning: context imbalance in 'hidraw_ioctl': wrong count at exit
drivers/hid/hidraw.c:267:9: context 'kernel_lock': wanted 0, got 1
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hidraw.c')
| -rw-r--r-- | drivers/hid/hidraw.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c index 1c23813995aa..894d52e05bf9 100644 --- a/drivers/hid/hidraw.c +++ b/drivers/hid/hidraw.c @@ -264,6 +264,7 @@ static long hidraw_ioctl(struct file *file, unsigned int cmd, default: ret = -ENOTTY; } + unlock_kernel(); return ret; } |