diff options
| author | Colin Ian King <colin.king@canonical.com> | 2017-10-17 15:31:51 +0100 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2017-10-19 13:52:38 +0200 |
| commit | 6cb6d98abdb06de867e34fde92912fdb89477897 (patch) | |
| tree | d0ff26c6d5f20599cb606849de471ecd58329699 /drivers/hid/hid-lg4ff.c | |
| parent | 47af1cdb309c65b36230b44e77383ed53b503d0e (diff) | |
| download | lwn-6cb6d98abdb06de867e34fde92912fdb89477897.tar.gz lwn-6cb6d98abdb06de867e34fde92912fdb89477897.zip | |
HID: hid-logitech: remove redundant assignment to pointer value
The pointer value is being assigned a value and this is never read, and later
on it is being assigned a new value. This the first assignment is redundant
and can be removed and hence also the variables report and report_list. Cleans
up the clang warning: Value stored to 'value' during its initialization is
never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-lg4ff.c')
| -rw-r--r-- | drivers/hid/hid-lg4ff.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c index 1fc12e357035..512d67e1aae3 100644 --- a/drivers/hid/hid-lg4ff.c +++ b/drivers/hid/hid-lg4ff.c @@ -474,9 +474,7 @@ static int lg4ff_play(struct input_dev *dev, void *data, struct ff_effect *effec static void lg4ff_set_autocenter_default(struct input_dev *dev, u16 magnitude) { struct hid_device *hid = input_get_drvdata(dev); - struct list_head *report_list = &hid->report_enum[HID_OUTPUT_REPORT].report_list; - struct hid_report *report = list_entry(report_list->next, struct hid_report, list); - s32 *value = report->field[0]->value; + s32 *value; u32 expand_a, expand_b; struct lg4ff_device_entry *entry; struct lg_drv_data *drv_data; |