diff options
| author | Mikko Perttunen <mperttunen@nvidia.com> | 2023-09-01 14:15:07 +0300 |
|---|---|---|
| committer | Thierry Reding <treding@nvidia.com> | 2023-10-11 22:52:43 +0200 |
| commit | 9764723de613d93b72e95923d25d589f539f07e9 (patch) | |
| tree | e7b9367c749506b05ac520a45c299737bd7413bb /drivers/gpu/host1x/channel.c | |
| parent | f170bed50f9bbc4b03673f40c91f84d4d0258409 (diff) | |
| download | lwn-9764723de613d93b72e95923d25d589f539f07e9.tar.gz lwn-9764723de613d93b72e95923d25d589f539f07e9.zip | |
gpu: host1x: Add locking in channel allocation
Add locking around channel allocation to avoid race conditions.
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230901111510.663401-1-cyndis@kapsi.fi
Diffstat (limited to 'drivers/gpu/host1x/channel.c')
| -rw-r--r-- | drivers/gpu/host1x/channel.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/gpu/host1x/channel.c b/drivers/gpu/host1x/channel.c index 2d0051d6314c..79501c957532 100644 --- a/drivers/gpu/host1x/channel.c +++ b/drivers/gpu/host1x/channel.c @@ -27,6 +27,8 @@ int host1x_channel_list_init(struct host1x_channel_list *chlist, return -ENOMEM; } + mutex_init(&chlist->lock); + return 0; } @@ -104,8 +106,11 @@ static struct host1x_channel *acquire_unused_channel(struct host1x *host) unsigned int max_channels = host->info->nb_channels; unsigned int index; + mutex_lock(&chlist->lock); + index = find_first_zero_bit(chlist->allocated_channels, max_channels); if (index >= max_channels) { + mutex_unlock(&chlist->lock); dev_err(host->dev, "failed to find free channel\n"); return NULL; } @@ -114,6 +119,8 @@ static struct host1x_channel *acquire_unused_channel(struct host1x *host) set_bit(index, chlist->allocated_channels); + mutex_unlock(&chlist->lock); + return &chlist->channels[index]; } |