diff options
| author | Maxime Ripard <maxime@cerno.tech> | 2022-08-29 15:11:54 +0200 |
|---|---|---|
| committer | Maxime Ripard <maxime@cerno.tech> | 2022-09-07 10:30:47 +0200 |
| commit | fad08d6248f88c9420eff5471ad34978a5c6c805 (patch) | |
| tree | ea3669bdace1be76777a35fe3493599105b0d9ec /drivers/gpu/drm/sun4i | |
| parent | 7c4180b151fca559d2bf1bf321f35ac8509fdc8c (diff) | |
| download | lwn-fad08d6248f88c9420eff5471ad34978a5c6c805.tar.gz lwn-fad08d6248f88c9420eff5471ad34978a5c6c805.zip | |
drm/sun4i: tv: Add missing reset assertion
The reset line is deasserted at bind, and asserted if we ever encounter an
error there. However, it's never asserted in unbind which will lead to a
resource unbalance.
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20220728-rpi-analog-tv-properties-v2-40-459522d653a7@cerno.tech
Diffstat (limited to 'drivers/gpu/drm/sun4i')
| -rw-r--r-- | drivers/gpu/drm/sun4i/sun4i_tv.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c index d3bf8fb3f6db..5965a0f72fc3 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tv.c +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c @@ -610,6 +610,7 @@ static void sun4i_tv_unbind(struct device *dev, struct device *master, drm_connector_cleanup(&tv->connector); drm_encoder_cleanup(&tv->encoder); clk_disable_unprepare(tv->clk); + reset_control_assert(tv->reset); } static const struct component_ops sun4i_tv_ops = { |