diff options
| author | Kevin Tang <kevin3.tang@gmail.com> | 2021-12-24 21:37:00 +0800 |
|---|---|---|
| committer | kevin3.tang <kevin3.tang@gmail.com> | 2022-02-14 21:53:17 +0800 |
| commit | 73792e6e66be1225837cc1a40f1e39b1d077751c (patch) | |
| tree | 08b40421b5e97c23012961f25fa3d9136f9de131 /drivers/gpu/drm/sprd | |
| parent | 8668658aebb0a19d877d5a81c004baf716c4aaa6 (diff) | |
| download | lwn-73792e6e66be1225837cc1a40f1e39b1d077751c.tar.gz lwn-73792e6e66be1225837cc1a40f1e39b1d077751c.zip | |
drm/sprd: check the platform_get_resource() return value
platform_get_resource() may fail and return NULL, so check it's value
before using it.
Reported-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: Kevin Tang <kevin3.tang@gmail.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/all/20220117084156.9338-1-kevin3.tang@gmail.com
v1 -> v2:
- new patch
Diffstat (limited to 'drivers/gpu/drm/sprd')
| -rw-r--r-- | drivers/gpu/drm/sprd/sprd_dpu.c | 5 | ||||
| -rw-r--r-- | drivers/gpu/drm/sprd/sprd_dsi.c | 5 |
2 files changed, 10 insertions, 0 deletions
diff --git a/drivers/gpu/drm/sprd/sprd_dpu.c b/drivers/gpu/drm/sprd/sprd_dpu.c index 06a3414ee43a..1637203ea103 100644 --- a/drivers/gpu/drm/sprd/sprd_dpu.c +++ b/drivers/gpu/drm/sprd/sprd_dpu.c @@ -790,6 +790,11 @@ static int sprd_dpu_context_init(struct sprd_dpu *dpu, int ret; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + dev_err(dev, "failed to get I/O resource\n"); + return -EINVAL; + } + ctx->base = devm_ioremap(dev, res->start, resource_size(res)); if (!ctx->base) { dev_err(dev, "failed to map dpu registers\n"); diff --git a/drivers/gpu/drm/sprd/sprd_dsi.c b/drivers/gpu/drm/sprd/sprd_dsi.c index 911b3cddc264..12b67a5d5923 100644 --- a/drivers/gpu/drm/sprd/sprd_dsi.c +++ b/drivers/gpu/drm/sprd/sprd_dsi.c @@ -907,6 +907,11 @@ static int sprd_dsi_context_init(struct sprd_dsi *dsi, struct resource *res; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + dev_err(dev, "failed to get I/O resource\n"); + return -EINVAL; + } + ctx->base = devm_ioremap(dev, res->start, resource_size(res)); if (!ctx->base) { drm_err(dsi->drm, "failed to map dsi host registers\n"); |