diff options
| author | Jerome Glisse <jglisse@redhat.com> | 2010-01-22 15:19:00 +0100 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2010-02-01 11:33:11 +1000 |
| commit | ff82f052d2a187dd0fa0e431ba70eb457c71a40e (patch) | |
| tree | 65bf2788445c3087cdb6c05fe2d40e81629ffd3b /drivers/gpu/drm/radeon/radeon.h | |
| parent | 5ffdb658f605cbc420944e7c7eeec9fbb8a73772 (diff) | |
| download | lwn-ff82f052d2a187dd0fa0e431ba70eb457c71a40e.tar.gz lwn-ff82f052d2a187dd0fa0e431ba70eb457c71a40e.zip | |
drm/radeon/kms: Bailout of blit if error happen & protect with mutex V3
If an error happen in r600_blit_prepare_copy report it rather
than WARNING and keeping execution. For instance if ib allocation
failed we did just warn about but then latter tried to access
NULL ib ptr causing oops. This patch also protect r600_copy_blit
with a mutex as otherwise one process might overwrite blit temporary
data with new one possibly leading to GPU lockup.
Should partialy or totaly fix:
https://bugzilla.redhat.com/show_bug.cgi?id=553279
V2 failing blit initialization is not fatal, fallback to memcpy when
this happen
V3 init blit before startup as we pin in startup, remove duplicate
code (this one was actualy tested unlike V2)
Signed-off-by: Jerome Glisse <jglisse@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/radeon/radeon.h')
| -rw-r--r-- | drivers/gpu/drm/radeon/radeon.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h index f7df1a7e4413..2d5f2bfa7201 100644 --- a/drivers/gpu/drm/radeon/radeon.h +++ b/drivers/gpu/drm/radeon/radeon.h @@ -416,6 +416,7 @@ struct r600_ih { }; struct r600_blit { + struct mutex mutex; struct radeon_bo *shader_obj; u64 shader_gpu_addr; u32 vs_offset, ps_offset; |