diff options
| author | Bruno Prémont <bonbons@linux-vserver.org> | 2014-12-21 17:43:44 +0100 |
|---|---|---|
| committer | Rob Clark <robdclark@gmail.com> | 2015-02-01 15:30:25 -0500 |
| commit | 925c1e7f716e14c848676ff70a442fe9e80d6e75 (patch) | |
| tree | b94f706412df0019e641488d02903ba7cb89d879 /drivers/gpu/drm/msm/mdp | |
| parent | 475ac0a13dfe108b80fbb89f54414de1a07a0d25 (diff) | |
| download | lwn-925c1e7f716e14c848676ff70a442fe9e80d6e75.tar.gz lwn-925c1e7f716e14c848676ff70a442fe9e80d6e75.zip | |
drm/msm: Do not BUG_ON(!spin_is_locked()) on UP
On !SMP systems spinlocks do not exist. Thus checking of they
are active will always fail.
Use
assert_spin_locked(lock);
instead of
BUG_ON(!spin_is_locked(lock));
to not BUG() on all UP systems.
Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
[robclark: drop stray ')']
Signed-off-by: Rob Clark <robdclark@gmail.com>
Diffstat (limited to 'drivers/gpu/drm/msm/mdp')
| -rw-r--r-- | drivers/gpu/drm/msm/mdp/mdp_kms.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/msm/mdp/mdp_kms.c b/drivers/gpu/drm/msm/mdp/mdp_kms.c index 2a731722d840..1988c243f437 100644 --- a/drivers/gpu/drm/msm/mdp/mdp_kms.c +++ b/drivers/gpu/drm/msm/mdp/mdp_kms.c @@ -34,7 +34,7 @@ static void update_irq(struct mdp_kms *mdp_kms) struct mdp_irq *irq; uint32_t irqmask = mdp_kms->vblank_mask; - BUG_ON(!spin_is_locked(&list_lock)); + assert_spin_locked(&list_lock); list_for_each_entry(irq, &mdp_kms->irq_list, node) irqmask |= irq->irqmask; |