diff options
| author | Chris Wilson <chris@chris-wilson.co.uk> | 2016-04-07 07:29:18 +0100 |
|---|---|---|
| committer | Chris Wilson <chris@chris-wilson.co.uk> | 2016-04-08 11:45:05 +0100 |
| commit | cffa781e59070cf115525a57e8f6042bd4e2bf7c (patch) | |
| tree | 4fd10698e69b6129ea83bbbc22f50aff6048880d /drivers/gpu/drm/i915/i915_irq.c | |
| parent | 7c90b7de7372fcd634fa0cffea6e580fb32e6b85 (diff) | |
| download | lwn-cffa781e59070cf115525a57e8f6042bd4e2bf7c.tar.gz lwn-cffa781e59070cf115525a57e8f6042bd4e2bf7c.zip | |
drm/i915: Simplify check for idleness in hangcheck
Having fixed the tracking of the engine's last_submitted_seqno, we can
now rely on it for detecting when the engine is idle (and not have to
touch the requests pointer).
Testcase: igt/gem_exec_whisper
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1460010558-10705-9-git-send-email-chris@chris-wilson.co.uk
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Diffstat (limited to 'drivers/gpu/drm/i915/i915_irq.c')
| -rw-r--r-- | drivers/gpu/drm/i915/i915_irq.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index cc9081249836..c30a12ef6daf 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -2805,9 +2805,8 @@ static void gen8_disable_vblank(struct drm_device *dev, unsigned int pipe) static bool ring_idle(struct intel_engine_cs *engine, u32 seqno) { - return (list_empty(&engine->request_list) || - i915_seqno_passed(seqno, - READ_ONCE(engine->last_submitted_seqno))); + return i915_seqno_passed(seqno, + READ_ONCE(engine->last_submitted_seqno)); } static bool |