diff options
| author | Philipp Stanner <pstanner@redhat.com> | 2023-09-20 14:36:12 +0200 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2023-10-09 16:59:49 +1000 |
| commit | f37d63e219c39199a59b8b8a211412ff27192830 (patch) | |
| tree | ba38a9a818725cac947bcc8b541468a20d9f03f8 /drivers/gpu/drm/drm_lease.c | |
| parent | ca0776571d3163bd03b3e8c9e3da936abfaecbf6 (diff) | |
| download | lwn-f37d63e219c39199a59b8b8a211412ff27192830.tar.gz lwn-f37d63e219c39199a59b8b8a211412ff27192830.zip | |
drm_lease.c: copy user-array safely
Currently, there is no overflow-check with memdup_user().
Use the new function memdup_array_user() instead of memdup_user() for
duplicating the user-space array safely.
Suggested-by: David Airlie <airlied@redhat.com>
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Zack Rusin <zackr@vmware.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230920123612.16914-6-pstanner@redhat.com
Diffstat (limited to 'drivers/gpu/drm/drm_lease.c')
| -rw-r--r-- | drivers/gpu/drm/drm_lease.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c index 150fe1555068..94375c6a5425 100644 --- a/drivers/gpu/drm/drm_lease.c +++ b/drivers/gpu/drm/drm_lease.c @@ -510,8 +510,8 @@ int drm_mode_create_lease_ioctl(struct drm_device *dev, /* Handle leased objects, if any */ idr_init(&leases); if (object_count != 0) { - object_ids = memdup_user(u64_to_user_ptr(cl->object_ids), - array_size(object_count, sizeof(__u32))); + object_ids = memdup_array_user(u64_to_user_ptr(cl->object_ids), + object_count, sizeof(__u32)); if (IS_ERR(object_ids)) { ret = PTR_ERR(object_ids); idr_destroy(&leases); |