summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/drm_fb_helper.c
diff options
context:
space:
mode:
authorLucas Stach <l.stach@pengutronix.de>2017-11-29 12:04:31 +0100
committerMaarten Lankhorst <maarten.lankhorst@linux.intel.com>2017-11-29 15:16:17 +0100
commita76dfe350c1fcb466b18595e65b33fa6abf65472 (patch)
tree2c9cf2bc316ae8b0006795d9c8c0b189b3561783 /drivers/gpu/drm/drm_fb_helper.c
parent1420edf7a3fbc9b8b0bbe24c3724d582dd4def28 (diff)
downloadlwn-a76dfe350c1fcb466b18595e65b33fa6abf65472.tar.gz
lwn-a76dfe350c1fcb466b18595e65b33fa6abf65472.zip
drm/atomic: make drm_atomic_helper_wait_for_vblanks more agressive
drm_atomic_helper_setup_commit expects that flipping of previous commits has happened when it is called to set up a new commit. This can be violated by commits where userspace doesn't get a flip completion event to synchronize against i.e. legacy modesets and property changes. The expectation is that those are done by blocking commits, which wait for completion. Most drivers call drm_atomic_helper_wait_for_vblanks in the commit_tail to ensure completion, but the wait for next vblank might not actually happen if the commit didn't change any planes. Make the wait more agressive by also waiting if no planes changed. This is the minimal regression fix for the 4.15 kernel series. Long term drivers should switch away from drm_atomic_helper_wait_for_vblanks and use drm_atomic_helper_wait_for_flip_done instead. Fixes: de39bec1a0c4 ("drm/atomic: Remove waits in drm_atomic_helper_commit_cleanup_done, v2.") Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20171129110431.6300-1-l.stach@pengutronix.de
Diffstat (limited to 'drivers/gpu/drm/drm_fb_helper.c')
0 files changed, 0 insertions, 0 deletions