diff options
| author | Jani Nikula <jani.nikula@intel.com> | 2022-10-24 15:33:37 +0300 |
|---|---|---|
| committer | Jani Nikula <jani.nikula@intel.com> | 2022-10-26 09:53:24 +0300 |
| commit | 90b575f52c6ab35979968e2e4d9cbd9f1eb3901c (patch) | |
| tree | 19a09fadde3c5bff070b7cee6693d50c50e30394 /drivers/gpu/drm/drm_connector.c | |
| parent | 6c9b3db70aad556152cba7291e93ae9e4bb1a6b0 (diff) | |
| download | lwn-90b575f52c6ab35979968e2e4d9cbd9f1eb3901c.tar.gz lwn-90b575f52c6ab35979968e2e4d9cbd9f1eb3901c.zip | |
drm/edid: detach debugfs EDID override from EDID property update
Having the EDID override debugfs directly update the EDID property is
problematic. The update is partial only. The driver has no way of
knowing it's been updated. Mode list is not updated. It's an
inconsistent state.
Detach debugfs EDID override from the property update completely. Only
set and reset a separate override EDID copy from debugfs, and have it
take effect only at detect (via EDID read). The copy is at
connector->edid_override, protected by connector->edid_override_mutex.
This also brings override EDID closer to firmware EDID in behaviour.
Add validation of the override EDID which we completely lacked.
Note that IGT already forces a detect whenever tests update the override
EDID.
v2: Add locking (Ville)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/4c875f8e06c4499f498fcf876e1233cbb155ec8a.1666614699.git.jani.nikula@intel.com
Diffstat (limited to 'drivers/gpu/drm/drm_connector.c')
| -rw-r--r-- | drivers/gpu/drm/drm_connector.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 90dad87e9ad0..223ff2666c3c 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -274,6 +274,7 @@ static int __drm_connector_init(struct drm_device *dev, INIT_LIST_HEAD(&connector->probed_modes); INIT_LIST_HEAD(&connector->modes); mutex_init(&connector->mutex); + mutex_init(&connector->edid_override_mutex); connector->edid_blob_ptr = NULL; connector->epoch_counter = 0; connector->tile_blob_ptr = NULL; |