diff options
| author | Dongliang Mu <mudongliangabcd@gmail.com> | 2022-09-19 11:12:49 +0800 |
|---|---|---|
| committer | Bartosz Golaszewski <brgl@bgdev.pl> | 2022-09-21 09:31:22 +0200 |
| commit | 21a9acc162457402c74c5c1e16471fda6eb090c0 (patch) | |
| tree | 5d1ffb84ed8db117d2d746d9da14ecb37c036623 /drivers/gpio/gpio-tqmx86.c | |
| parent | ab637d48363d7b8ee67ae089808a8bc6051d53c4 (diff) | |
| download | lwn-21a9acc162457402c74c5c1e16471fda6eb090c0.tar.gz lwn-21a9acc162457402c74c5c1e16471fda6eb090c0.zip | |
gpio: tqmx86: fix uninitialized variable girq
The commit 924610607f19 ("gpio: tpmx86: Move PM device over to
irq domain") adds a dereference of girq that may be uninitialized.
Fix this by moving irq_domain_set_pm_device into if true branch
as suggested by Marc Zyngier.
Fixes: 924610607f19 ("gpio: tpmx86: Move PM device over to irq domain")
Suggested-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Acked-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Diffstat (limited to 'drivers/gpio/gpio-tqmx86.c')
| -rw-r--r-- | drivers/gpio/gpio-tqmx86.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-tqmx86.c b/drivers/gpio/gpio-tqmx86.c index fa4bc7481f9a..e739dcea61b2 100644 --- a/drivers/gpio/gpio-tqmx86.c +++ b/drivers/gpio/gpio-tqmx86.c @@ -307,6 +307,8 @@ static int tqmx86_gpio_probe(struct platform_device *pdev) girq->default_type = IRQ_TYPE_NONE; girq->handler = handle_simple_irq; girq->init_valid_mask = tqmx86_init_irq_valid_mask; + + irq_domain_set_pm_device(girq->domain, dev); } ret = devm_gpiochip_add_data(dev, chip, gpio); @@ -315,8 +317,6 @@ static int tqmx86_gpio_probe(struct platform_device *pdev) goto out_pm_dis; } - irq_domain_set_pm_device(girq->domain, dev); - dev_info(dev, "GPIO functionality initialized with %d pins\n", chip->ngpio); |