diff options
author | Tony Prisk <linux@prisktech.co.nz> | 2013-01-18 17:58:22 +1300 |
---|---|---|
committer | Grant Likely <grant.likely@secretlab.ca> | 2013-02-11 22:21:29 +0000 |
commit | 9f01d30ee191a74f1e7a2ac0710f064f472d000a (patch) | |
tree | 7be3599e3068977c27a1cb0052d38f0fdb895f2f /drivers/gpio/gpio-omap.c | |
parent | 362432aed5e5b497a8cf7b20c268ba71df93c045 (diff) | |
download | lwn-9f01d30ee191a74f1e7a2ac0710f064f472d000a.tar.gz lwn-9f01d30ee191a74f1e7a2ac0710f064f472d000a.zip |
gpio/vt8500: memory cleanup missing
This driver is missing a .remove callback, and the fail path on
probe is incomplete.
If an error occurs in vt8500_add_chips, gpio_base is not unmapped.
The driver is also ignoring the return value from this function so
if a chip fails to register it completes as successful.
Replaced pr_err with dev_err in vt8500_add_chips since the device is
available.
There is also no .remove callback defined so the function is added.
Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Diffstat (limited to 'drivers/gpio/gpio-omap.c')
0 files changed, 0 insertions, 0 deletions