diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2020-05-07 09:42:52 +0000 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2020-05-13 16:42:07 +0200 |
| commit | 43d7ce70ae43dd8523754b17f567417e0e75dbce (patch) | |
| tree | 16bd8bcb2701a48f209a43d86842270605422099 /drivers/gnss | |
| parent | 2ef96a5bb12be62ef75b5828c0aab838ebb29cb8 (diff) | |
| download | lwn-43d7ce70ae43dd8523754b17f567417e0e75dbce.tar.gz lwn-43d7ce70ae43dd8523754b17f567417e0e75dbce.zip | |
gnss: sirf: fix error return code in sirf_probe()
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
This avoids a use-after-free in case the driver is later unbound.
Fixes: d2efbbd18b1e ("gnss: add driver for sirfstar-based receivers")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
[ johan: amend commit message; mention potential use-after-free ]
Cc: stable <stable@vger.kernel.org> # 4.19
Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/gnss')
| -rw-r--r-- | drivers/gnss/sirf.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/gnss/sirf.c b/drivers/gnss/sirf.c index effed3a8d398..2ecb1d3e8eeb 100644 --- a/drivers/gnss/sirf.c +++ b/drivers/gnss/sirf.c @@ -439,14 +439,18 @@ static int sirf_probe(struct serdev_device *serdev) data->on_off = devm_gpiod_get_optional(dev, "sirf,onoff", GPIOD_OUT_LOW); - if (IS_ERR(data->on_off)) + if (IS_ERR(data->on_off)) { + ret = PTR_ERR(data->on_off); goto err_put_device; + } if (data->on_off) { data->wakeup = devm_gpiod_get_optional(dev, "sirf,wakeup", GPIOD_IN); - if (IS_ERR(data->wakeup)) + if (IS_ERR(data->wakeup)) { + ret = PTR_ERR(data->wakeup); goto err_put_device; + } ret = regulator_enable(data->vcc); if (ret) |