diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2022-07-30 18:28:46 +0200 |
|---|---|---|
| committer | Jean Delvare <jdelvare@suse.de> | 2022-07-30 18:28:46 +0200 |
| commit | d2139dfca361a1f5bfc4d4a23455b1a409a69cd4 (patch) | |
| tree | e56dd8df626980cc7323d3fb25abeec6a5bd3ae1 /drivers/firmware | |
| parent | 4b0986a3613c92f4ec1bdc7f60ec66fea135991f (diff) | |
| download | lwn-d2139dfca361a1f5bfc4d4a23455b1a409a69cd4.tar.gz lwn-d2139dfca361a1f5bfc4d4a23455b1a409a69cd4.zip | |
firmware: dmi: Use the proper accessor for the version field
The byte at offset 6 represents length. Don't take it and drop it
immediately by using proper accessor, i.e. get_unaligned_be24().
[JD: Change the subject to something less frightening]
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Diffstat (limited to 'drivers/firmware')
| -rw-r--r-- | drivers/firmware/dmi_scan.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c index f191a1f901ac..0eb6b617f709 100644 --- a/drivers/firmware/dmi_scan.c +++ b/drivers/firmware/dmi_scan.c @@ -630,7 +630,7 @@ static int __init dmi_smbios3_present(const u8 *buf) { if (memcmp(buf, "_SM3_", 5) == 0 && buf[6] < 32 && dmi_checksum(buf, buf[6])) { - dmi_ver = get_unaligned_be32(buf + 6) & 0xFFFFFF; + dmi_ver = get_unaligned_be24(buf + 7); dmi_num = 0; /* No longer specified */ dmi_len = get_unaligned_le32(buf + 12); dmi_base = get_unaligned_le64(buf + 16); |