diff options
| author | Qiushi Wu <wu000273@umn.edu> | 2020-05-28 13:38:04 -0500 |
|---|---|---|
| committer | Ard Biesheuvel <ardb@kernel.org> | 2020-06-15 14:38:56 +0200 |
| commit | 4ddf4739be6e375116c375f0a68bf3893ffcee21 (patch) | |
| tree | 7ccbf8e4adbb5fdd00ab292f32ccc0eb4ced523b /drivers/firmware/efi | |
| parent | 7dfc06a0f25b593a9f51992f540c0f80a57f3629 (diff) | |
| download | lwn-4ddf4739be6e375116c375f0a68bf3893ffcee21.tar.gz lwn-4ddf4739be6e375116c375f0a68bf3893ffcee21.zip | |
efi/esrt: Fix reference count leak in esre_create_sysfs_entry.
kobject_init_and_add() takes reference even when it fails.
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object. Previous
commit "b8eb718348b8" fixed a similar problem.
Fixes: 0bb549052d33 ("efi: Add esrt support")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Link: https://lore.kernel.org/r/20200528183804.4497-1-wu000273@umn.edu
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Diffstat (limited to 'drivers/firmware/efi')
| -rw-r--r-- | drivers/firmware/efi/esrt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c index e3d692696583..d5915272141f 100644 --- a/drivers/firmware/efi/esrt.c +++ b/drivers/firmware/efi/esrt.c @@ -181,7 +181,7 @@ static int esre_create_sysfs_entry(void *esre, int entry_num) rc = kobject_init_and_add(&entry->kobj, &esre1_ktype, NULL, "entry%d", entry_num); if (rc) { - kfree(entry); + kobject_put(&entry->kobj); return rc; } } |