diff options
| author | Johan Hovold <johan@kernel.org> | 2018-06-12 14:43:34 +0200 |
|---|---|---|
| committer | Borislav Petkov <bp@suse.de> | 2018-06-17 13:09:44 +0200 |
| commit | 4708aa85d50cc6e962dfa8acf5ad4e0d290a21db (patch) | |
| tree | fad36b23fc027cd1d0bb171025af0fdb4ad347cb /drivers/edac | |
| parent | 9d72fe1ce81bc757ecb6d57b58e5fd95b9ad1b26 (diff) | |
| download | lwn-4708aa85d50cc6e962dfa8acf5ad4e0d290a21db.tar.gz lwn-4708aa85d50cc6e962dfa8acf5ad4e0d290a21db.zip | |
EDAC: Fix memleak in module init error path
Make sure to use put_device() to free the initialised struct device so
that resources managed by driver core also gets released in the event of
a registration failure.
Signed-off-by: Johan Hovold <johan@kernel.org>
Cc: Denis Kirjanov <kirjanov@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-edac <linux-edac@vger.kernel.org>
Fixes: 2d56b109e3a5 ("EDAC: Handle error path in edac_mc_sysfs_init() properly")
Link: http://lkml.kernel.org/r/20180612124335.6420-1-johan@kernel.org
Signed-off-by: Borislav Petkov <bp@suse.de>
Diffstat (limited to 'drivers/edac')
| -rw-r--r-- | drivers/edac/edac_mc_sysfs.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 7481955160a4..20374b8248f0 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b/drivers/edac/edac_mc_sysfs.c @@ -1075,14 +1075,14 @@ int __init edac_mc_sysfs_init(void) err = device_add(mci_pdev); if (err < 0) - goto out_dev_free; + goto out_put_device; edac_dbg(0, "device %s created\n", dev_name(mci_pdev)); return 0; - out_dev_free: - kfree(mci_pdev); + out_put_device: + put_device(mci_pdev); out: return err; } |