diff options
| author | Siddharth Vadapalli <s-vadapalli@ti.com> | 2024-06-02 07:03:19 +0530 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2024-06-11 23:10:44 +0530 |
| commit | ba27e9d2207784da748b19170a2e56bd7770bd81 (patch) | |
| tree | e590093735a7979fbcc48288fc08cc942166c203 /drivers/dma | |
| parent | e3215deca4520773cd2b155bed164c12365149a7 (diff) | |
| download | lwn-ba27e9d2207784da748b19170a2e56bd7770bd81.tar.gz lwn-ba27e9d2207784da748b19170a2e56bd7770bd81.zip | |
dmaengine: ti: k3-udma-glue: Fix of_k3_udma_glue_parse_chn_by_id()
The of_k3_udma_glue_parse_chn_by_id() helper function erroneously
invokes "of_node_put()" on the "udmax_np" device-node passed to it,
without having incremented its reference count at any point. Fix it.
Fixes: 81a1f90f20af ("dmaengine: ti: k3-udma-glue: Add function to parse channel by ID")
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Acked-by: Peter Ujfalusi@gmail.com
Link: https://lore.kernel.org/r/20240602013319.2975894-1-s-vadapalli@ti.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/ti/k3-udma-glue.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c index c9b93055dc9d..f0a399cf45b2 100644 --- a/drivers/dma/ti/k3-udma-glue.c +++ b/drivers/dma/ti/k3-udma-glue.c @@ -200,12 +200,9 @@ of_k3_udma_glue_parse_chn_by_id(struct device_node *udmax_np, struct k3_udma_glu ret = of_k3_udma_glue_parse(udmax_np, common); if (ret) - goto out_put_spec; + return ret; ret = of_k3_udma_glue_parse_chn_common(common, thread_id, tx_chn); - -out_put_spec: - of_node_put(udmax_np); return ret; } |