diff options
| author | Keguang Zhang <keguang.zhang@gmail.com> | 2024-08-31 17:41:09 +0800 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2024-09-02 13:56:32 +0530 |
| commit | e0bee4bcdc3238ebcae6e5960544b9e3d0a62abf (patch) | |
| tree | e94e6ebe26ec24ff731d561c44f922623a1f39e6 /drivers/dma | |
| parent | a688efea0f2a084aee372e5b7b12d4d2d172f99a (diff) | |
| download | lwn-e0bee4bcdc3238ebcae6e5960544b9e3d0a62abf.tar.gz lwn-e0bee4bcdc3238ebcae6e5960544b9e3d0a62abf.zip | |
dmaengine: loongson1-apb-dma: Fix the build warning caused by the size of pdev_irqname
drivers/dma/loongson1-apb-dma.c: In function 'ls1x_dma_probe':
drivers/dma/loongson1-apb-dma.c:531:42: warning: '%d' directive writing between 1 and 8 bytes into a region of size 2 [-Wformat-overflow=]
531 | sprintf(pdev_irqname, "ch%d", id);
| ^~
In function 'ls1x_dma_chan_probe',
inlined from 'ls1x_dma_probe' at drivers/dma/loongson1-apb-dma.c:605:8:
drivers/dma/loongson1-apb-dma.c:531:39: note: directive argument in the range [0, 19522579]
531 | sprintf(pdev_irqname, "ch%d", id);
| ^~~~~~
drivers/dma/loongson1-apb-dma.c:531:17: note: 'sprintf' output between 4 and 11 bytes into a destination of size 4
531 | sprintf(pdev_irqname, "ch%d", id);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fix the array size and use snprintf() instead of sprintf().
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202408302108.xIR18jmD-lkp@intel.com/
Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
Link: https://lore.kernel.org/r/20240831-fix-loongson1-dma-v1-1-91376d87695c@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/loongson1-apb-dma.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/dma/loongson1-apb-dma.c b/drivers/dma/loongson1-apb-dma.c index ca43c67a8203..255fe7eca212 100644 --- a/drivers/dma/loongson1-apb-dma.c +++ b/drivers/dma/loongson1-apb-dma.c @@ -526,9 +526,9 @@ static int ls1x_dma_chan_probe(struct platform_device *pdev, for (id = 0; id < dma->nr_chans; id++) { struct ls1x_dma_chan *chan = &dma->chan[id]; - char pdev_irqname[4]; + char pdev_irqname[16]; - sprintf(pdev_irqname, "ch%d", id); + snprintf(pdev_irqname, sizeof(pdev_irqname), "ch%d", id); chan->irq = platform_get_irq_byname(pdev, pdev_irqname); if (chan->irq < 0) return dev_err_probe(&pdev->dev, chan->irq, |