diff options
| author | Ben Dooks <ben.dooks@sifive.com> | 2022-07-08 18:01:53 +0100 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2022-07-21 18:03:09 +0530 |
| commit | 820f5ce999d2f99961e88c16d65cd26764df0590 (patch) | |
| tree | e26345f5301503a6745a59ddec7b4a75d7d5744f /drivers/dma | |
| parent | 86cb0defe0e275453bc39e856bb523eb425a6537 (diff) | |
| download | lwn-820f5ce999d2f99961e88c16d65cd26764df0590.tar.gz lwn-820f5ce999d2f99961e88c16d65cd26764df0590.zip | |
dmaengine: dw-axi-dmac: ignore interrupt if no descriptor
If the channel has no descriptor and the interrupt is raised then the
kernel will OOPS. Check the result of vchan_next_desc() in the handler
axi_chan_block_xfer_complete() to avoid the error happening.
Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
Link: https://lore.kernel.org/r/20220708170153.269991-4-ben.dooks@sifive.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index abc2a919a11c..c62809dfeae3 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -1054,6 +1054,11 @@ static void axi_chan_block_xfer_complete(struct axi_dma_chan *chan) /* The completed descriptor currently is in the head of vc list */ vd = vchan_next_desc(&chan->vc); + if (!vd) { + dev_err(chan2dev(chan), "BUG: %s, IRQ with no descriptors\n", + axi_chan_name(chan)); + goto out; + } if (chan->cyclic) { desc = vd_to_axi_desc(vd); @@ -1083,6 +1088,7 @@ static void axi_chan_block_xfer_complete(struct axi_dma_chan *chan) axi_chan_start_first_queued(chan); } +out: spin_unlock_irqrestore(&chan->vc.lock, flags); } |