diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2023-05-15 13:32:10 +0300 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2023-05-19 16:54:04 +0530 |
| commit | 4d43acb145c363626d76f49febb4240c488cd1cf (patch) | |
| tree | 0aa8d482ceb227f8d174ab8ce49612ff65a3842c /drivers/dma/pl330.c | |
| parent | 38de368a66360f1859428d5e191b45bd01c20786 (diff) | |
| download | lwn-4d43acb145c363626d76f49febb4240c488cd1cf.tar.gz lwn-4d43acb145c363626d76f49febb4240c488cd1cf.zip | |
dmaengine: at_xdmac: fix potential Oops in at_xdmac_prep_interleaved()
There are two place if the at_xdmac_interleaved_queue_desc() fails which
could lead to a NULL dereference where "first" is NULL and we call
list_add_tail(&first->desc_node, ...). In the first caller, the return
is not checked so add a check for that. In the next caller, the return
is checked but if it fails on the first iteration through the loop then
it will lead to a NULL pointer dereference.
Fixes: 4e5385784e69 ("dmaengine: at_xdmac: handle numf > 1")
Fixes: 62b5cb757f1d ("dmaengine: at_xdmac: fix memory leak in interleaved mode")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Link: https://lore.kernel.org/r/21282b66-9860-410a-83df-39c17fcf2f1b@kili.mountain
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/pl330.c')
0 files changed, 0 insertions, 0 deletions