summaryrefslogtreecommitdiff
path: root/drivers/dma/mmp_tdma.c
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2015-01-13 14:31:46 +0100
committerVinod Koul <vinod.koul@intel.com>2015-01-13 21:20:10 +0530
commit3c20ba5fb5b9e3d5e266bfab316ee10b77da88e0 (patch)
tree798b9be045fb50fdbf23c3e1deb85da14bb6123e /drivers/dma/mmp_tdma.c
parent2f56eaff2010326848f13c4a1e468a2dd1527f0b (diff)
downloadlwn-3c20ba5fb5b9e3d5e266bfab316ee10b77da88e0.tar.gz
lwn-3c20ba5fb5b9e3d5e266bfab316ee10b77da88e0.zip
dmaengine: mmp-tdma: fix terminate_all return code
In a recent cleanup, the mmp_tdma_terminate_all function was introduced but does not set a proper return value. Almost no slave driver uses that return value, but if one does, the result will be undefined, which the compiler warns about: dma/mmp_tdma.c: In function 'mmp_tdma_terminate_all': dma/mmp_tdma.c:474:1: warning: no return statement in function returning non-void [-Wreturn-type] This changes the driver to return zero, like most other drivers do. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: f43a6fd400ba6 ("dmaengine: mmp-tdma: Split device_control") Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma/mmp_tdma.c')
-rw-r--r--drivers/dma/mmp_tdma.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c
index 91fb241102f7..70c2fa9963cd 100644
--- a/drivers/dma/mmp_tdma.c
+++ b/drivers/dma/mmp_tdma.c
@@ -471,6 +471,8 @@ static int mmp_tdma_terminate_all(struct dma_chan *chan)
mmp_tdma_disable_chan(chan);
/* disable interrupt */
mmp_tdma_enable_irq(tdmac, false);
+
+ return 0;
}
static int mmp_tdma_config(struct dma_chan *chan,