diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2021-07-30 23:27:15 +0300 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2021-08-06 21:48:11 +0530 |
| commit | 67db87dc8284070adb15b3c02c1c31d5cf51c5d6 (patch) | |
| tree | 476e76c7c5b963161032b08d28d391bff499bc83 /drivers/dma/acpi-dma.c | |
| parent | d803c8b9f3f2b8e5c047f2d0a27a9ea3ef91510f (diff) | |
| download | lwn-67db87dc8284070adb15b3c02c1c31d5cf51c5d6.tar.gz lwn-67db87dc8284070adb15b3c02c1c31d5cf51c5d6.zip | |
dmaengine: acpi: Avoid comparison GSI with Linux vIRQ
Currently the CRST parsing relies on the fact that on most of x86 devices
the IRQ mapping is 1:1 with Linux vIRQ. However, it may be not true for
some. Fix this by converting GSI to Linux vIRQ before checking it.
Fixes: ee8209fd026b ("dma: acpi-dma: parse CSRT to extract additional resources")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210730202715.24375-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/acpi-dma.c')
| -rw-r--r-- | drivers/dma/acpi-dma.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/drivers/dma/acpi-dma.c b/drivers/dma/acpi-dma.c index 235f1396f968..52768dc8ce12 100644 --- a/drivers/dma/acpi-dma.c +++ b/drivers/dma/acpi-dma.c @@ -70,10 +70,14 @@ static int acpi_dma_parse_resource_group(const struct acpi_csrt_group *grp, si = (const struct acpi_csrt_shared_info *)&grp[1]; - /* Match device by MMIO and IRQ */ + /* Match device by MMIO */ if (si->mmio_base_low != lower_32_bits(mem) || - si->mmio_base_high != upper_32_bits(mem) || - si->gsi_interrupt != irq) + si->mmio_base_high != upper_32_bits(mem)) + return 0; + + /* Match device by Linux vIRQ */ + ret = acpi_register_gsi(NULL, si->gsi_interrupt, si->interrupt_mode, si->interrupt_polarity); + if (ret != irq) return 0; dev_dbg(&adev->dev, "matches with %.4s%04X (rev %u)\n", |