diff options
| author | Ezequiel Garcia <ezequiel@collabora.com> | 2019-06-21 18:39:49 -0300 |
|---|---|---|
| committer | MyungJoo Ham <myungjoo.ham@samsung.com> | 2019-08-24 20:11:12 +0900 |
| commit | 7544fd7f384591038646d3cd9efb311ab4509e24 (patch) | |
| tree | 77e3ad9912bd3e312b8322fb405505ecd8f8af73 /drivers/devfreq | |
| parent | 0a453aca94bd7886bca86cc78ce2771f55152232 (diff) | |
| download | lwn-7544fd7f384591038646d3cd9efb311ab4509e24.tar.gz lwn-7544fd7f384591038646d3cd9efb311ab4509e24.zip | |
PM / devfreq: Fix kernel oops on governor module load
A bit unexpectedly (but still documented), request_module may
return a positive value, in case of a modprobe error.
This is currently causing issues in the devfreq framework.
When a request_module exits with a positive value, we currently
return that via ERR_PTR. However, because the value is positive,
it's not a ERR_VALUE proper, and is therefore treated as a
valid struct devfreq_governor pointer, leading to a kernel oops.
Fix this by returning -EINVAL if request_module returns a positive
value.
Fixes: b53b0128052ff ("PM / devfreq: Fix static checker warning in try_then_request_governor")
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Diffstat (limited to 'drivers/devfreq')
| -rw-r--r-- | drivers/devfreq/devfreq.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index bed647637a93..784c08e4f931 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -254,7 +254,7 @@ static struct devfreq_governor *try_then_request_governor(const char *name) /* Restore previous state before return */ mutex_lock(&devfreq_list_lock); if (err) - return ERR_PTR(err); + return (err < 0) ? ERR_PTR(err) : ERR_PTR(-EINVAL); governor = find_devfreq_governor(name); } |