diff options
| author | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2023-08-22 13:28:02 +0200 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2023-08-23 18:25:04 +0200 |
| commit | 78aabcb3211aa4b7e8f8a1d5d4bdad699a42d4ba (patch) | |
| tree | 47f8b274169399a96cdaf1af57b62e1f6beca3ac /drivers/cpuidle | |
| parent | 5484e31bbbff285f9505c4766373f840ffb746e5 (diff) | |
| download | lwn-78aabcb3211aa4b7e8f8a1d5d4bdad699a42d4ba.tar.gz lwn-78aabcb3211aa4b7e8f8a1d5d4bdad699a42d4ba.zip | |
cpuidle: teo: Avoid unnecessary variable assignments
Notice that it is not necessary to assign tick_intercept_sum in every
iteration of the first loop over idle states in teo_select(), because
the intercept_sum value does not change after the assignment in a
given iteration of the loop, so its value after the last iteration of
the loop can be used for computing the tick_intercept_sum value
directly.
Modify the code accordingly.
No intentional functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/cpuidle')
| -rw-r--r-- | drivers/cpuidle/governors/teo.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/cpuidle/governors/teo.c b/drivers/cpuidle/governors/teo.c index 31050fdc633f..7244f71c59c5 100644 --- a/drivers/cpuidle/governors/teo.c +++ b/drivers/cpuidle/governors/teo.c @@ -450,8 +450,6 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, hit_sum += prev_bin->hits; recent_sum += prev_bin->recent; - tick_intercept_sum = intercept_sum; - if (dev->states_usage[i].disable) continue; @@ -484,7 +482,8 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, goto end; } - tick_intercept_sum += cpu_data->state_bins[drv->state_count-1].intercepts; + tick_intercept_sum = intercept_sum + + cpu_data->state_bins[drv->state_count-1].intercepts; /* * If the sum of the intercepts metric for all of the idle states |