diff options
| author | Pali Rohár <pali@kernel.org> | 2021-04-08 13:42:20 +0200 |
|---|---|---|
| committer | Viresh Kumar <viresh.kumar@linaro.org> | 2021-04-09 15:17:33 +0530 |
| commit | 92963903a8e11b9576eb7249f8e81eefa93b6f96 (patch) | |
| tree | 098e5498333237b3352f21ce24f44b401518ab03 /drivers/cpufreq/armada-37xx-cpufreq.c | |
| parent | e93033aff684641f71a436ca7a9d2a742126baaf (diff) | |
| download | lwn-92963903a8e11b9576eb7249f8e81eefa93b6f96.tar.gz lwn-92963903a8e11b9576eb7249f8e81eefa93b6f96.zip | |
cpufreq: armada-37xx: Fix driver cleanup when registration failed
Commit 8db82563451f ("cpufreq: armada-37xx: fix frequency calculation for
opp") changed calculation of frequency passed to the dev_pm_opp_add()
function call. But the code for dev_pm_opp_remove() function call was not
updated, so the driver cleanup phase does not work when registration fails.
This fixes the issue by using the same frequency in both calls.
Signed-off-by: Pali Rohár <pali@kernel.org>
Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Tested-by: Tomasz Maciej Nowak <tmn505@gmail.com>
Tested-by: Anders Trier Olesen <anders.trier.olesen@gmail.com>
Tested-by: Philip Soares <philips@netisense.com>
Fixes: 8db82563451f ("cpufreq: armada-37xx: fix frequency calculation for opp")
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Diffstat (limited to 'drivers/cpufreq/armada-37xx-cpufreq.c')
| -rw-r--r-- | drivers/cpufreq/armada-37xx-cpufreq.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c index c7683d447b11..1ab2113daef5 100644 --- a/drivers/cpufreq/armada-37xx-cpufreq.c +++ b/drivers/cpufreq/armada-37xx-cpufreq.c @@ -521,7 +521,7 @@ disable_dvfs: remove_opp: /* clean-up the already added opp before leaving */ while (load_lvl-- > ARMADA_37XX_DVFS_LOAD_0) { - freq = cur_frequency / dvfs->divider[load_lvl]; + freq = base_frequency / dvfs->divider[load_lvl]; dev_pm_opp_remove(cpu_dev, freq); } |