diff options
| author | Stephen Boyd <sboyd@kernel.org> | 2020-09-23 17:41:44 -0700 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2020-10-07 19:08:38 -0700 |
| commit | b608f11d49ec671739604cc763248d8e8fadbbeb (patch) | |
| tree | cf50589379935c8d5c5bf26935297e8101e342eb /drivers/clk/rockchip/clk-half-divider.c | |
| parent | ca52a47af60f791b08a540a8e14d8f5751ee63e9 (diff) | |
| download | lwn-b608f11d49ec671739604cc763248d8e8fadbbeb.tar.gz lwn-b608f11d49ec671739604cc763248d8e8fadbbeb.zip | |
clk: rockchip: Initialize hw to error to avoid undefined behavior
We can get down to this return value from ERR_CAST() without
initializing hw. Set it to -ENOMEM so that we always return something
sane.
Fixes the following smatch warning:
drivers/clk/rockchip/clk-half-divider.c:228 rockchip_clk_register_halfdiv() error: uninitialized symbol 'hw'.
drivers/clk/rockchip/clk-half-divider.c:228 rockchip_clk_register_halfdiv() warn: passing zero to 'ERR_CAST'
Cc: Elaine Zhang <zhangqing@rock-chips.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Fixes: 956060a52795 ("clk: rockchip: add support for half divider")
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers/clk/rockchip/clk-half-divider.c')
| -rw-r--r-- | drivers/clk/rockchip/clk-half-divider.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clk/rockchip/clk-half-divider.c b/drivers/clk/rockchip/clk-half-divider.c index e97fd3dfbae7..ccd5c270c213 100644 --- a/drivers/clk/rockchip/clk-half-divider.c +++ b/drivers/clk/rockchip/clk-half-divider.c @@ -166,7 +166,7 @@ struct clk *rockchip_clk_register_halfdiv(const char *name, unsigned long flags, spinlock_t *lock) { - struct clk_hw *hw; + struct clk_hw *hw = ERR_PTR(-ENOMEM); struct clk_mux *mux = NULL; struct clk_gate *gate = NULL; struct clk_divider *div = NULL; |