summaryrefslogtreecommitdiff
path: root/drivers/clk/qcom/gcc-apq8084.c
diff options
context:
space:
mode:
authorStephen Boyd <sboyd@codeaurora.org>2015-11-09 14:30:54 -0800
committerStephen Boyd <sboyd@codeaurora.org>2015-11-20 13:14:43 -0800
commit329cabcecf94d8d7821e729dda284ba9dec44c87 (patch)
treeff1e8d8b9b603391726803b13a10db77c69280bb /drivers/clk/qcom/gcc-apq8084.c
parent96cb6933403ce9136b49b002ceb8da82037f4fe4 (diff)
downloadlwn-329cabcecf94d8d7821e729dda284ba9dec44c87.tar.gz
lwn-329cabcecf94d8d7821e729dda284ba9dec44c87.zip
clk: qcom: Specify LE device endianness
All these clock controllers are little endian devices, but so far we've been relying on the regmap mmio bus handling this for us without explicitly stating that fact. After commit 4a98da2164cf (regmap-mmio: Use native endianness for read/write, 2015-10-29), the regmap mmio bus will read/write with the __raw_*() IO accessors, instead of using the readl/writel() APIs that do proper byte swapping for little endian devices. So if we're running on a big endian processor and haven't specified the endianness explicitly in the regmap config or in DT, we're going to switch from doing little endian byte swapping to big endian accesses without byte swapping, leading to some confusing results. On my apq8074 dragonboard, this causes the device to fail to boot as we access the clock controller with big endian IO accesses even though the device is little endian. Specify the endianness explicitly so that the regmap core properly byte swaps the accesses for us. Reported-by: Kevin Hilman <khilman@linaro.org> Tested-by: Tyler Baker <tyler.baker@linaro.org> Tested-by: Kevin Hilman <khilman@linaro.org> Cc: Simon Arlott <simon@fire.lp0.eu> Cc: Mark Brown <broonie@kernel.org> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Diffstat (limited to 'drivers/clk/qcom/gcc-apq8084.c')
-rw-r--r--drivers/clk/qcom/gcc-apq8084.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/clk/qcom/gcc-apq8084.c b/drivers/clk/qcom/gcc-apq8084.c
index 070037a29ea5..cf73e539e9f6 100644
--- a/drivers/clk/qcom/gcc-apq8084.c
+++ b/drivers/clk/qcom/gcc-apq8084.c
@@ -3587,6 +3587,7 @@ static const struct regmap_config gcc_apq8084_regmap_config = {
.val_bits = 32,
.max_register = 0x1fc0,
.fast_io = true,
+ .val_format_endian = REGMAP_ENDIAN_LITTLE,
};
static const struct qcom_cc_desc gcc_apq8084_desc = {