diff options
author | Chen-Yu Tsai <wenst@chromium.org> | 2022-02-08 20:40:32 +0800 |
---|---|---|
committer | Stephen Boyd <sboyd@kernel.org> | 2022-02-17 12:12:25 -0800 |
commit | f3e690b00b86d2b2182b70433993fb038515f086 (patch) | |
tree | f1d9526b0e650333a4adb871ffc7a4d9b1bf222c /drivers/clk/mediatek/clk-mt8195-vdo0.c | |
parent | cd3a77a085f5449696aed6f8f350241d4be509e8 (diff) | |
download | lwn-f3e690b00b86d2b2182b70433993fb038515f086.tar.gz lwn-f3e690b00b86d2b2182b70433993fb038515f086.zip |
clk: mediatek: mt8195: Implement error handling in probe functions
Until now the mediatek clk driver library did not have any way to
unregister clks, and so all drivers did not do proper cleanup in
their error paths.
Now that the library does have APIs to unregister clks, use them
in the error path of the probe functions for the mt8195 clk drivers
to do proper cleanup.
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Link: https://lore.kernel.org/r/20220208124034.414635-30-wenst@chromium.org
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers/clk/mediatek/clk-mt8195-vdo0.c')
-rw-r--r-- | drivers/clk/mediatek/clk-mt8195-vdo0.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/clk/mediatek/clk-mt8195-vdo0.c b/drivers/clk/mediatek/clk-mt8195-vdo0.c index f7ff7618c714..af34eb564b1d 100644 --- a/drivers/clk/mediatek/clk-mt8195-vdo0.c +++ b/drivers/clk/mediatek/clk-mt8195-vdo0.c @@ -105,10 +105,12 @@ static int clk_mt8195_vdo0_probe(struct platform_device *pdev) r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); if (r) - goto free_vdo0_data; + goto unregister_gates; return r; +unregister_gates: + mtk_clk_unregister_gates(vdo0_clks, ARRAY_SIZE(vdo0_clks), clk_data); free_vdo0_data: mtk_free_clk_data(clk_data); return r; |