diff options
| author | Stephen Boyd <sboyd@kernel.org> | 2019-12-26 14:09:27 -0800 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2020-01-04 23:21:08 -0800 |
| commit | 2d2699926143624ef0fce3bbb5a0f089d674d12c (patch) | |
| tree | 1209cb2957868f62dd93d4c804b09330fe964ecc /drivers/clk/clk.c | |
| parent | 12ead77432f2ce32dea797742316d15c5800cb32 (diff) | |
| download | lwn-2d2699926143624ef0fce3bbb5a0f089d674d12c.tar.gz lwn-2d2699926143624ef0fce3bbb5a0f089d674d12c.zip | |
clk: Warn about critical clks that fail to enable
If we don't warn here users of the CLK_IS_CRITICAL flag may not know
that their clk isn't actually enabled because it silently fails to
enable. Let's print a warning in that case so developers find these
problems faster.
Suggested-by: Jerome Brunet <jbrunet@baylibre.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lkml.kernel.org/r/20200102005503.71923-1-sboyd@kernel.org
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/clk/clk.c')
| -rw-r--r-- | drivers/clk/clk.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 772258de2d1f..b03c2be4014b 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -3427,13 +3427,18 @@ static int __clk_core_init(struct clk_core *core) unsigned long flags; ret = clk_core_prepare(core); - if (ret) + if (ret) { + pr_warn("%s: critical clk '%s' failed to prepare\n", + __func__, core->name); goto out; + } flags = clk_enable_lock(); ret = clk_core_enable(core); clk_enable_unlock(flags); if (ret) { + pr_warn("%s: critical clk '%s' failed to enable\n", + __func__, core->name); clk_core_unprepare(core); goto out; } |