summaryrefslogtreecommitdiff
path: root/drivers/char
diff options
context:
space:
mode:
authorLuck, Tony <tony.luck@intel.com>2011-11-16 10:50:56 -0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-08-15 12:04:11 -0700
commit21a465d5868b83e17a1c2434864fbb95b6414481 (patch)
tree5fc0d5eadd1353ad4017660fa6aa2d74ef02993c /drivers/char
parent6133313b3bcbd0473feac85c8a8d7ef704ff2279 (diff)
downloadlwn-21a465d5868b83e17a1c2434864fbb95b6414481.tar.gz
lwn-21a465d5868b83e17a1c2434864fbb95b6414481.zip
fix typo/thinko in get_random_bytes()
commit bd29e568a4cb6465f6e5ec7c1c1f3ae7d99cbec1 upstream. If there is an architecture-specific random number generator we use it to acquire randomness one "long" at a time. We should put these random words into consecutive words in the result buffer - not just overwrite the first word again and again. Signed-off-by: Tony Luck <tony.luck@intel.com> Acked-by: H. Peter Anvin <hpa@zytor.com> Acked-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/char')
-rw-r--r--drivers/char/random.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 154eeda26db5..8b47c2b57437 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -941,7 +941,7 @@ void get_random_bytes(void *buf, int nbytes)
if (!arch_get_random_long(&v))
break;
- memcpy(buf, &v, chunk);
+ memcpy(p, &v, chunk);
p += chunk;
nbytes -= chunk;
}