diff options
| author | Peter Botha <peterb@goldcircle.co.za> | 2009-06-09 17:16:32 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-06-09 18:09:03 -0700 |
| commit | 96050dfb25966612008dcea7d342e91fa01e993c (patch) | |
| tree | 787b6337a9ef0ad018181218e9d36c883998c090 /drivers/char/mxser.c | |
| parent | a61d90d75d0f9e86432c45b496b4b0fbf0fd03dc (diff) | |
| download | lwn-96050dfb25966612008dcea7d342e91fa01e993c.tar.gz lwn-96050dfb25966612008dcea7d342e91fa01e993c.zip | |
char: mxser, fix ISA board lookup
There's a bug in the mxser kernel module that still appears in the
2.6.29.4 kernel.
mxser_get_ISA_conf takes a ioaddress as its first argument, by passing the
not of the ioaddr, you're effectively passing 0 which means it won't be
able to talk to an ISA card. I have tested this, and removing the !
fixes the problem.
Cc: "Peter Botha" <peterb@goldcircle.co.za>
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char/mxser.c')
| -rw-r--r-- | drivers/char/mxser.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c index a420e8d437dd..13f8871e5b21 100644 --- a/drivers/char/mxser.c +++ b/drivers/char/mxser.c @@ -2711,7 +2711,7 @@ static int __init mxser_module_init(void) continue; brd = &mxser_boards[m]; - retval = mxser_get_ISA_conf(!ioaddr[b], brd); + retval = mxser_get_ISA_conf(ioaddr[b], brd); if (retval <= 0) { brd->info = NULL; continue; |