diff options
| author | Dinghao Liu <dinghao.liu@zju.edu.cn> | 2021-01-02 13:47:55 +0800 |
|---|---|---|
| committer | Marcel Holtmann <marcel@holtmann.org> | 2021-01-06 08:46:10 +0100 |
| commit | 71f8e707557b9bc25dc90a59a752528d4e7c1cbf (patch) | |
| tree | d29b4f2262c4f6b1c49e60983df3861fba3d8aad /drivers/bluetooth | |
| parent | f272f185d259e2d574b4868fe8fb0ee56f3c2cfa (diff) | |
| download | lwn-71f8e707557b9bc25dc90a59a752528d4e7c1cbf.tar.gz lwn-71f8e707557b9bc25dc90a59a752528d4e7c1cbf.zip | |
Bluetooth: hci_qca: Fix memleak in qca_controller_memdump
When __le32_to_cpu() fails, qca_memdump should be freed
just like when vmalloc() fails.
Fixes: d841502c79e3f ("Bluetooth: hci_qca: Collect controller memory dump during SSR")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'drivers/bluetooth')
| -rw-r--r-- | drivers/bluetooth/hci_qca.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 4a963682c702..5dbcb7c42b80 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -1024,7 +1024,9 @@ static void qca_controller_memdump(struct work_struct *work) dump_size = __le32_to_cpu(dump->dump_size); if (!(dump_size)) { bt_dev_err(hu->hdev, "Rx invalid memdump size"); + kfree(qca_memdump); kfree_skb(skb); + qca->qca_memdump = NULL; mutex_unlock(&qca->hci_memdump_lock); return; } |