diff options
| author | Cathy Avery <cathy.avery@oracle.com> | 2015-10-02 09:35:01 -0400 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2015-11-15 12:51:51 -0500 |
| commit | ff6f66f679e83d69c869de459dad3bc0f4783c63 (patch) | |
| tree | 0a1e7f924d8562be7757e25c46290e240d9caba2 /drivers/block | |
| parent | 0b3fefd2408019fc37c9e9125fdea8d1220b7e7b (diff) | |
| download | lwn-ff6f66f679e83d69c869de459dad3bc0f4783c63.tar.gz lwn-ff6f66f679e83d69c869de459dad3bc0f4783c63.zip | |
xen-blkfront: check for null drvdata in blkback_changed (XenbusStateClosing)
[ Upstream commit a54c8f0f2d7df525ff997e2afe71866a1a013064 ]
xen-blkfront will crash if the check to talk_to_blkback()
in blkback_changed()(XenbusStateInitWait) returns an error.
The driver data is freed and info is set to NULL. Later during
the close process via talk_to_blkback's call to xenbus_dev_fatal()
the null pointer is passed to and dereference in blkfront_closing.
CC: stable@vger.kernel.org
Signed-off-by: Cathy Avery <cathy.avery@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'drivers/block')
| -rw-r--r-- | drivers/block/xen-blkfront.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 218c4858f494..34a01f191b33 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1911,7 +1911,8 @@ static void blkback_changed(struct xenbus_device *dev, break; /* Missed the backend's Closing state -- fallthrough */ case XenbusStateClosing: - blkfront_closing(info); + if (info) + blkfront_closing(info); break; } } |