diff options
| author | Eric Sesterhenn / Snakebyte <snakebyte@gmx.de> | 2007-05-23 13:58:15 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-05-23 20:14:15 -0700 |
| commit | 4acb3e2f97f41cf9b53182b494384467d3ceb304 (patch) | |
| tree | a315110b3aae508db20303c92daae467efc8ad1d /drivers/block | |
| parent | fa74419bb7b51af4bbb66116d14cc92f0b5aff25 (diff) | |
| download | lwn-4acb3e2f97f41cf9b53182b494384467d3ceb304.tar.gz lwn-4acb3e2f97f41cf9b53182b494384467d3ceb304.zip | |
Off by one in floppy.c
Another coverity patch i forgot to resend, original thread here
http://marc.info/?l=linux-kernel&m=115144559823592&w=2
In case drive == N_DRIVE, we get one past the drive_params array.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/block')
| -rw-r--r-- | drivers/block/floppy.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index 3587cb434371..fe088045dd08 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -670,7 +670,7 @@ static void __reschedule_timeout(int drive, const char *message, int marg) if (drive == current_reqD) drive = current_drive; del_timer(&fd_timeout); - if (drive < 0 || drive > N_DRIVE) { + if (drive < 0 || drive >= N_DRIVE) { fd_timeout.expires = jiffies + 20UL * HZ; drive = 0; } else |