diff options
| author | Omar Sandoval <osandov@fb.com> | 2018-10-11 12:20:41 -0700 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2018-10-16 09:49:08 -0600 |
| commit | 1448a2a5360ae06f25e2edc61ae070dff5c0beb4 (patch) | |
| tree | 880b3eeb679e9b96cd52c52c677a258a224ef16d /drivers/block/swim.c | |
| parent | 891b7c5fbf619d2a314e424775b3c232eb227e90 (diff) | |
| download | lwn-1448a2a5360ae06f25e2edc61ae070dff5c0beb4.tar.gz lwn-1448a2a5360ae06f25e2edc61ae070dff5c0beb4.zip | |
swim: fix cleanup on setup error
If we fail to allocate the request queue for a disk, we still need to
free that disk, not just the previous ones. Additionally, we need to
cleanup the previous request queues.
Signed-off-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/block/swim.c')
| -rw-r--r-- | drivers/block/swim.c | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/drivers/block/swim.c b/drivers/block/swim.c index 0e31884a9519..cbe909c51847 100644 --- a/drivers/block/swim.c +++ b/drivers/block/swim.c @@ -887,8 +887,17 @@ static int swim_floppy_init(struct swim_priv *swd) exit_put_disks: unregister_blkdev(FLOPPY_MAJOR, "fd"); - while (drive--) - put_disk(swd->unit[drive].disk); + do { + struct gendisk *disk = swd->unit[drive].disk; + + if (disk) { + if (disk->queue) { + blk_cleanup_queue(disk->queue); + disk->queue = NULL; + } + put_disk(disk); + } + } while (drive--); return err; } |