diff options
| author | Murali Iyer <mniyer@us.ibm.com> | 2015-03-26 11:07:51 -0500 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2015-03-31 10:39:56 -0600 |
| commit | f137e0f15101c0a0ff8a5d956042e50247f1fef9 (patch) | |
| tree | df638613293871220dc168438bd4f74f6db68061 /drivers/block/nvme-core.c | |
| parent | 1efccc9ddb98fd533169669160201b027562af7e (diff) | |
| download | lwn-f137e0f15101c0a0ff8a5d956042e50247f1fef9.tar.gz lwn-f137e0f15101c0a0ff8a5d956042e50247f1fef9.zip | |
nvme: Fix PRP list calculation for non-4k system page size
PRP list calculation is supposed to be based on device's page size.
Systems with page size larger than device's page size cause corruption
to the name space as well as system memory with out this fix.
Systems like x86 might not experience this issue because it uses
PAGE_SIZE of 4K where as powerpc uses PAGE_SIZE of 64k while NVMe device's
page size varies depending upon the vendor.
Signed-off-by: Murali Iyer <mniyer@us.ibm.com>
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Acked-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/block/nvme-core.c')
| -rw-r--r-- | drivers/block/nvme-core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c index c12c95cf2e55..4dc858b43c92 100644 --- a/drivers/block/nvme-core.c +++ b/drivers/block/nvme-core.c @@ -640,12 +640,12 @@ int nvme_setup_prps(struct nvme_dev *dev, struct nvme_iod *iod, int total_len, struct scatterlist *sg = iod->sg; int dma_len = sg_dma_len(sg); u64 dma_addr = sg_dma_address(sg); - int offset = offset_in_page(dma_addr); + u32 page_size = dev->page_size; + int offset = dma_addr & (page_size - 1); __le64 *prp_list; __le64 **list = iod_list(iod); dma_addr_t prp_dma; int nprps, i; - u32 page_size = dev->page_size; length -= (page_size - offset); if (length <= 0) |