diff options
author | Uwe Kleine-König <u.kleine-koenig@baylibre.com> | 2024-06-13 23:23:52 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-06-20 12:48:09 +0200 |
commit | 2f3cfd2f4b7cf3026fe6b9b2a5320cc18f4c184e (patch) | |
tree | cbb0867b3668051a305fd66aff8540c4e825a38c /drivers/base | |
parent | de6582833db0e695ba0c548e3cc2ad7dbb6aa260 (diff) | |
download | lwn-2f3cfd2f4b7cf3026fe6b9b2a5320cc18f4c184e.tar.gz lwn-2f3cfd2f4b7cf3026fe6b9b2a5320cc18f4c184e.zip |
driver core: Make dev_err_probe() silent for -ENOMEM
For an out-of-memory error there should be no additional output. Adapt
dev_err_probe() to not emit the error message when err is -ENOMEM.
This simplifies handling errors that might among others be -ENOMEM.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/3d1e308d45cddf67749522ca42d83f5b4f0b9634.1718311756.git.u.kleine-koenig@baylibre.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/base')
-rw-r--r-- | drivers/base/core.c | 17 |
1 files changed, 14 insertions, 3 deletions
diff --git a/drivers/base/core.c b/drivers/base/core.c index 2b4c0624b704..730cae66607c 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -5021,11 +5021,22 @@ int dev_err_probe(const struct device *dev, int err, const char *fmt, ...) vaf.fmt = fmt; vaf.va = &args; - if (err != -EPROBE_DEFER) { - dev_err(dev, "error %pe: %pV", ERR_PTR(err), &vaf); - } else { + switch (err) { + case -EPROBE_DEFER: device_set_deferred_probe_reason(dev, &vaf); dev_dbg(dev, "error %pe: %pV", ERR_PTR(err), &vaf); + break; + + case -ENOMEM: + /* + * We don't print anything on -ENOMEM, there is already enough + * output. + */ + break; + + default: + dev_err(dev, "error %pe: %pV", ERR_PTR(err), &vaf); + break; } va_end(args); |