diff options
| author | Stuart Hayes <stuart.w.hayes@gmail.com> | 2024-08-22 15:28:02 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-09-03 13:05:08 +0200 |
| commit | ba6353748e71bd1d7e422fec2b5c2e2dfc2e3bd9 (patch) | |
| tree | 6eac4b9479aafafe22c7d4d6046485dc869efa37 /drivers/base | |
| parent | 24e041e1e48d06f25a12caaf73728a4ec2e511fe (diff) | |
| download | lwn-ba6353748e71bd1d7e422fec2b5c2e2dfc2e3bd9.tar.gz lwn-ba6353748e71bd1d7e422fec2b5c2e2dfc2e3bd9.zip | |
driver core: don't always lock parent in shutdown
Don't lock a parent device unless it is needed in device_shutdown. This
is in preparation for making device shutdown asynchronous, when it will
be needed to allow children of a common parent to shut down
simultaneously.
Signed-off-by: Stuart Hayes <stuart.w.hayes@gmail.com>
Signed-off-by: David Jeffery <djeffery@redhat.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Tested-by: Keith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20240822202805.6379-2-stuart.w.hayes@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/base')
| -rw-r--r-- | drivers/base/core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/base/core.c b/drivers/base/core.c index 30408a4a4927..988aff79ee7f 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -4816,7 +4816,7 @@ void device_shutdown(void) spin_unlock(&devices_kset->list_lock); /* hold lock to avoid race with probe/release */ - if (parent) + if (parent && dev->bus && dev->bus->need_parent_lock) device_lock(parent); device_lock(dev); @@ -4840,7 +4840,7 @@ void device_shutdown(void) } device_unlock(dev); - if (parent) + if (parent && dev->bus && dev->bus->need_parent_lock) device_unlock(parent); put_device(dev); |