diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2016-09-10 10:21:15 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-09-10 21:46:07 -0700 |
| commit | 0f0d0ed0870eca21e36dc520d7d9be292c103f80 (patch) | |
| tree | 62f373ae9dd82713d4dc2e48d30693ac83e13c5d /drivers/atm/zatm.c | |
| parent | 5ad3ea3d3952dcbb8047f97fbfa49804ea53a53a (diff) | |
| download | lwn-0f0d0ed0870eca21e36dc520d7d9be292c103f80.tar.gz lwn-0f0d0ed0870eca21e36dc520d7d9be292c103f80.zip | |
ATM-ZeitNet: Replace one kzalloc() call by kcalloc()
* The script "checkpatch.pl" can point information out like the following.
WARNING: Prefer kcalloc over kzalloc with multiply
Thus fix the affected source code place.
* Replace the specification of a data type by a pointer dereference
to make the corresponding size determination a bit safer according to
the Linux coding style convention.
* Delete the local variable "size" which became unnecessary with
this refactoring.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/atm/zatm.c')
| -rw-r--r-- | drivers/atm/zatm.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/atm/zatm.c b/drivers/atm/zatm.c index 218c6af60f21..2cc9e2a63d3e 100644 --- a/drivers/atm/zatm.c +++ b/drivers/atm/zatm.c @@ -598,12 +598,13 @@ static void close_rx(struct atm_vcc *vcc) static int start_rx(struct atm_dev *dev) { struct zatm_dev *zatm_dev; - int size,i; + int i; DPRINTK("start_rx\n"); zatm_dev = ZATM_DEV(dev); - size = sizeof(struct atm_vcc *)*zatm_dev->chans; - zatm_dev->rx_map = kzalloc(size,GFP_KERNEL); + zatm_dev->rx_map = kcalloc(zatm_dev->chans, + sizeof(*zatm_dev->rx_map), + GFP_KERNEL); if (!zatm_dev->rx_map) return -ENOMEM; /* set VPI/VCI split (use all VCIs and give what's left to VPIs) */ zpokel(zatm_dev,(1 << dev->ci_range.vci_bits)-1,uPD98401_VRR); |